[draft] ES6 import support

[mattdesl]

Fixes #56 and allows for detective to find import statements.

Note there is also detective-es6 which is probably better suited for common situations, since it doesn't consider require calls.

[zertosh]

Cool. A few things: (1) Deciding whether to look for imports based on an option that is already a default passed to acorn doesn't seem fitting. How about something like imports or includeImports? (2) The fast regex check needs to be fixed.

[mattdesl]

Yeah, good point. I'm also wondering whether this "es6 mode" should not look for require() statements.

Sent from my iPhone

On Sep 12, 2015, at 11:36 AM, Andres Suarez [email protected] wrote:

Cool. A few things: (1) Deciding whether to look for imports based on an option that is already a default passed to acorn doesn't seem fitting. How about something like imports or includeImports? (2) The fast regex check needs to be fixed.

—
Reply to this email directly or view it on GitHub.

[zertosh]

I'm also wondering whether this "es6 mode" should not look for require() statements.

Interesting point. Maybe the opts should be includeImports and onlyImports?

[mattdesl]

@zertosh I'm taking another stab at this.

How should the word option be affected? Should it optionally support an array like [ 'require', 'import' ]? Or should it just transparently default to both when { includeImports: true, onlyImports: false }?

[mattdesl]

The PR would be cleaner if opt.word was a regex, but this is a breaking change

[mattdesl]

Ok, things were starting to get really nasty in this PR, trying to support all the legacy options of detective.

I ended up creating a new module for my needs.
https://www.npmjs.com/package/detect-import-require

[goto-bus-stop]

I'll close this then in favour of using alternatives like detective-es6 or detect-import-require. thanks!