Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nd bias bootstrap #374

Merged
merged 33 commits into from
Jul 29, 2020
Merged

Nd bias bootstrap #374

merged 33 commits into from
Jul 29, 2020

Conversation

ndiamant
Copy link
Contributor

This builds on gn_sf_bias by replacing the scatter blots with bootstrapped performance by protected class. Here is an example running test scalar with protected tmaps (on an untrained model)

image

@ndiamant
Copy link
Contributor Author

ndiamant commented Jul 27, 2020

Adding counts per class and the top tertile to the cts case Done!
image

Copy link
Collaborator

@lucidtronix lucidtronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work everybody! a couple nits and a question about p values, but I tested it and it looks great no need to bounce back.

Also, look our ventricular rate regression seems to perform better in non genetic Caucasians:
per_class_pearson_VentricularRate

ml4cvd/plots.py Outdated Show resolved Hide resolved
ml4cvd/plots.py Outdated Show resolved Hide resolved
for performance, group_name in zip(performances, group_names):
performance_dict[group_col] += [group_name] * len(performance)
performance_dict[metric_name] += performance
sns.boxplot(x=group_col, y=metric_name, data=pd.DataFrame(performance_dict), ax=ax)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should also compute P-Values for the groups belonging to different distributions given these performances? (Can wait for another PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be another PR because it's not obvious to me how to calculate the p-value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndiamant ndiamant merged commit f1f1042 into master Jul 29, 2020
@ndiamant ndiamant deleted the nd_bias_bootstrap branch July 29, 2020 16:36
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
Adds protected tensor maps gathered during test set inference
Adds bootstrapped performance comparison per class of protected tensor maps
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
Adds protected tensor maps gathered during test set inference
Adds bootstrapped performance comparison per class of protected tensor maps
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
Adds protected tensor maps gathered during test set inference
Adds bootstrapped performance comparison per class of protected tensor maps
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
Adds protected tensor maps gathered during test set inference
Adds bootstrapped performance comparison per class of protected tensor maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants