fixes in tensor generator #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meant just run it before and after the change on any machine any make sure the performance is better. I don't think there's a practical way to write a test for this for now |
paolodi
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Great catch and great fixes @StevieSong ! Note that this PR allows our tests to pass (at the moment test_recipes.py hangs indefinitely). Just a suggestion inline to change variable names for the number of workers (please feel free to disregard if you prefer).
paolodi
reviewed
Jun 18, 2020
|
able to pass |
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #260
fixes #324
fixes #326
@ndiamant not sure how to implement a reliable test as suggested in #260, machines that we test on are variable...
@paolodi pr for tomorrow's meeting, had to additionally modify section so that stats q is emptied in main thread as well