Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix infinite loop in _on_epoch_end #326

Closed
StevenSong opened this issue Jun 15, 2020 · 0 comments · Fixed by #327
Closed

fix infinite loop in _on_epoch_end #326

StevenSong opened this issue Jun 15, 2020 · 0 comments · Fixed by #327
Assignees
@StevenSong
Labels
bug Something isn't working

Comments

@StevenSong
Copy link
Collaborator

this is to address the bug found in #323

What
_on_epoch_end has a bug in the loop that checks the stats_q. it gets stuck if num_workers == 0. this happens when num_workers is set to 0 or 1 as an argument (in the case of num_workers == 1, validation generator gets num_workers // 2 --> 1 // 2 == 0).

code segment: https://github.com/broadinstitute/ml/blob/e3540e1eff2fc45301255c1e89b87c8bb5d18405/ml4cvd/tensor_generators.py#L429-L430

Why
code gets stuck during training/validation

How
set self.num_workers = 1
also a good opportunity to address #260

Acceptance Criteria
code does not get stuck
@StevenSong StevenSong self-assigned this Jun 15, 2020
@StevenSong StevenSong mentioned this issue Jun 15, 2020
Closed
StevenSong added a commit that referenced this issue Jun 15, 2020
@StevenSong
#260 #324 #326
9d3a3b6
@StevenSong StevenSong mentioned this issue Jun 15, 2020
Merged
@erikr erikr added the bug Something isn't working label Jun 16, 2020
StevenSong added a commit that referenced this issue Jun 18, 2020
@StevenSong
fixes in tensor generator (#327)
9c3e6d7 
* #260 #324 #326

* get stats q

* variable names
lucidtronix pushed a commit that referenced this issue Jan 13, 2023
@StevenSong
fixes in tensor generator (#327)
f747f7c 
* #260 #324 #326

* get stats q

* variable names
lucidtronix pushed a commit that referenced this issue Jan 13, 2023
@StevenSong
fixes in tensor generator (#327)
f6554fe 
* #260 #324 #326

* get stats q

* variable names
lucidtronix pushed a commit that referenced this issue Jan 13, 2023
@StevenSong
fixes in tensor generator (#327)
b87dacb 
* #260 #324 #326

* get stats q

* variable names
lucidtronix pushed a commit that referenced this issue Jan 13, 2023
@StevenSong
fixes in tensor generator (#327)
140f765 
* #260 #324 #326

* get stats q

* variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StevenSong StevenSong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes in tensor generator broadinstitute/ml4h
2 participants
@erikr @StevenSong