Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-1470 Have Extract Cohort to PGEN write to cost_observability table #8958

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/variantstore/wdl/GvsExtractCallsetPgen.wdl
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ task PgenExtractTask {
${FILTERING_ARGS} \
--dataset-id ~{dataset_name} \
--call-set-identifier ~{call_set_identifier} \
--wdl-step GvsExtractCallsetPgenPgen \
--wdl-step GvsExtractCallsetPgen \
--wdl-call PgenExtractTask \
--shard-identifier ~{interval_filename} \
~{cost_observability_line} \
Expand Down
2 changes: 1 addition & 1 deletion scripts/variantstore/wdl/GvsUtils.wdl
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ task GetToolVersions {
String cloud_sdk_slim_docker = "gcr.io/google.com/cloudsdktool/cloud-sdk:435.0.0-slim"
String variants_docker = "us-central1-docker.pkg.dev/broad-dsde-methods/gvs/variants:2024-08-15-alpine-254df9be288d"
String variants_nirvana_docker = "us.gcr.io/broad-dsde-methods/variantstore:nirvana_2022_10_19"
String gatk_docker = "us-central1-docker.pkg.dev/broad-dsde-methods/gvs/gatk:2024_08_08-gatkbase-7dc245ec27ce"
String gatk_docker = "us-central1-docker.pkg.dev/broad-dsde-methods/gvs/gatk:2024_08_19-gatkbase-cd5b6b7821b2"
String real_time_genomics_docker = "docker.io/realtimegenomics/rtg-tools:latest"
String gotc_imputation_docker = "us.gcr.io/broad-gotc-prod/imputation-bcf-vcf:1.0.5-1.10.2-0.1.16-1649948623"
String plink_docker = "us-central1-docker.pkg.dev/broad-dsde-methods/gvs/plink2:2024-04-23-slim-a0a65f52cc0e"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ protected void apply(VariantContext variantContext) {

@Override
public Object onTraversalSuccess() {
if(pgenWriter.getDroppedVariantCount() > 0l) {
super.onTraversalSuccess();
if (pgenWriter.getDroppedVariantCount() > 0l) {
logger.info(pgenWriter.getDroppedVariantCount() + " variants dropped by writer for exceeding the" +
" maximum number of allowed alt alleles.");
}
Expand Down
Loading