-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sl dr update docker base image #8614
Conversation
…ationsIntegrationTest and TrainVariantAnnotationsModelIntegrationTest
072affd
to
4b62059
Compare
4b62059
to
da06b4a
Compare
@@ -72,4 +72,6 @@ RUN mkdir $DOWNLOAD_DIR && \ | |||
bash $DOWNLOAD_DIR/miniconda.sh -p $CONDA_PATH -b && \ | |||
rm $DOWNLOAD_DIR/miniconda.sh && \ | |||
conda clean -afy && \ | |||
conda config --set auto_update_conda false && \ | |||
conda config --set solver libmamba && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly needed, since libmamba is the default solver in newer conda versions, but it might be worth hinting at the new use of libmamba here.
@@ -72,4 +72,6 @@ RUN mkdir $DOWNLOAD_DIR && \ | |||
bash $DOWNLOAD_DIR/miniconda.sh -p $CONDA_PATH -b && \ | |||
rm $DOWNLOAD_DIR/miniconda.sh && \ | |||
conda clean -afy && \ | |||
conda config --set auto_update_conda false && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will hopefully ensure that devs experimenting with updates to the environment within the Docker don't inadvertently update to a different conda version, which might otherwise introduce discrepancies.
Closing this one, since the changes proposed here were incorporated into #8610 |
No description provided.