Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to give tables created by prepare step a two week TTL [VS-597] #8595

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

rsasch
Copy link

@rsasch rsasch commented Nov 30, 2023

See run here (and here, after PR changes) and then the tables created in gvs-internal.rsa_gvs_quickstart_dev.

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Have you run the integration tests

scripts/variantstore/wdl/GvsPrepareRangesCallset.wdl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #8595 (a2a0028) into ah_var_store (9ac0bef) will increase coverage by 33.585%.
Report is 34 commits behind head on ah_var_store.
The diff coverage is 68.224%.

❗ Current head a2a0028 differs from pull request most recent head a117d61. Consider uploading reports for the commit a117d61 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##             ah_var_store     #8595        +/-   ##
=====================================================
+ Coverage          52.150%   85.734%   +33.585%     
- Complexity          30538     40435      +9897     
=====================================================
  Files                2421      2425         +4     
  Lines              189608    191872      +2264     
  Branches            20679     21371       +692     
=====================================================
+ Hits                98880    164500     +65620     
+ Misses              84409     19971     -64438     
- Partials             6319      7401      +1082     
Files Coverage Δ
...itute/hellbender/tools/gvs/common/SchemaUtils.java 56.667% <100.000%> (+4.815%) ⬆️
...e/hellbender/tools/gvs/ingest/RefRangesWriter.java 50.000% <ø> (ø)
...e/hellbender/utils/gvs/bigquery/BigQueryUtils.java 31.606% <ø> (ø)
...ngest/CreateVariantIngestFilesIntegrationTest.java 100.000% <100.000%> (ø)
...te/hellbender/tools/gvs/utils/SchemaUtilsTest.java 100.000% <100.000%> (ø)
...itute/hellbender/tools/gvs/common/GQStateEnum.java 92.000% <93.750%> (-3.238%) ⬇️
...llbender/tools/gvs/ingest/RefRangesAvroWriter.java 0.000% <0.000%> (ø)
...ellbender/tools/gvs/ingest/RefRangesTsvWriter.java 95.833% <0.000%> (-4.167%) ⬇️
...der/tools/gvs/ingest/CreateVariantIngestFiles.java 44.186% <73.333%> (+3.386%) ⬆️
...hellbender/tools/gvs/ingest/RefRangesBQWriter.java 0.000% <0.000%> (ø)
... and 1 more

... and 634 files with indirect coverage changes

@rsasch
Copy link
Author

rsasch commented Nov 30, 2023

Looks good. Have you run the integration tests

I didn't run the integration test because it didn't seem necessary (no changes that effect the data, just the table(s) TTL). If you think I should, happy to kick it off.

@rsasch rsasch merged commit e219cfc into ah_var_store Dec 1, 2023
20 checks passed
@rsasch rsasch deleted the rsa_vs_597 branch December 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants