-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter to give tables created by prepare step a two week TTL [VS-597] #8595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Have you run the integration tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8595 +/- ##
=====================================================
+ Coverage 52.150% 85.734% +33.585%
- Complexity 30538 40435 +9897
=====================================================
Files 2421 2425 +4
Lines 189608 191872 +2264
Branches 20679 21371 +692
=====================================================
+ Hits 98880 164500 +65620
+ Misses 84409 19971 -64438
- Partials 6319 7401 +1082
|
I didn't run the integration test because it didn't seem necessary (no changes that effect the data, just the table(s) TTL). If you think I should, happy to kick it off. |
See run here (and here, after PR changes) and then the tables created in
gvs-internal.rsa_gvs_quickstart_dev
.