Update logic around missing sample data in TDM [VS-997] #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bulk_ingest_staging #8422 +/- ##
=======================================================
Coverage ? 44.447%
Complexity ? 24788
=======================================================
Files ? 2194
Lines ? 166533
Branches ? 17925
=======================================================
Hits ? 74019
Misses ? 87209
Partials ? 5305 |
gbggrant
approved these changes
Jul 18, 2023
| @@ -293,7 +293,7 @@ task ExtractFilterTask { | |||
| >>> | |||
|
|
|||
| runtime { | |||
| docker: "us.gcr.io/broad-dsde-methods/broad-gatk-snapshots:varstore_2023_07_14" | |||
| docker: "us.gcr.io/broad-dsde-methods/broad-gatk-snapshots:varstore_2023_07_17" | |||
There was a problem hiding this comment.
Why did you need to update this docker? It looks like only the python (variantstore) one had code changes
There was a problem hiding this comment.
to ensure that bulk_ingest_staging, the staging branch, is keeping up-to-date with java changes in ah_var_store
RoriCremer
approved these changes
Jul 18, 2023
mcovarr
pushed a commit
that referenced
this pull request
Jul 24, 2023
mcovarr
pushed a commit
that referenced
this pull request
Aug 10, 2023
mcovarr
pushed a commit
that referenced
this pull request
Aug 11, 2023
mcovarr
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated GATK docker to latest.
Latest run with missing columns here to show what "failing" looks like.
Quickstart integration failed because of https://broadworkbench.atlassian.net/browse/VS-1010.