VS-942. Fix an error where NO variants were found #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8388 +/- ##
================================================
Coverage ? 86.155%
Complexity ? 35521
================================================
Files ? 2194
Lines ? 166538
Branches ? 17925
================================================
Hits ? 143481
Misses ? 16674
Partials ? 6383 |
mcovarr
approved these changes
Jun 28, 2023
Remove entry from .dockstore.yml
mcovarr
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Fix a bug where there were NO variants in a range.
mcovarr
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Fix a bug where there were NO variants in a range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I found in testing. I was extracting all the samples for an Exome run and it was widely scattered. So there occurred a situation where there no VET entries in one of the shards and a NPE happened.
This PR fixes that and makes it tool generate an empty (well, has a header) VCF, which the GVS workflow can handle.
Failing workflow showing the problem here.
Passing workflow (after the fix) here
Passing Integration Test here