-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Beta User WDL to use bulk ingest [VS-982] #8379
Conversation
(Couldn't find ExtractCohortToVcf in ExtractTask method in GvsExtractCallset.wdl
Go with the official docker tag
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8379 +/- ##
================================================
Coverage ? 76.504%
Complexity ? 21795
================================================
Files ? 1392
Lines ? 83134
Branches ? 13184
================================================
Hits ? 63601
Misses ? 14369
Partials ? 5164 |
Github actions tests reported job failures from actions build 5404926238
|
Github actions tests reported job failures from actions build 5405169587
|
Github actions tests reported job failures from actions build 5405222155
|
Github actions tests reported job failures from actions build 5405579628
|
Github actions tests reported job failures from actions build 5405771210
|
@@ -243,13 +243,13 @@ def get_column_values(columnSamples, numSamples, user_defined_vcf, user_defined_ | |||
# Check the contents of the columns: the duck algorithm. If its contents LOOK like vcfs and indexes, go from there | |||
for col in path_ends_in_vcf_gz: | |||
# ...and has an analogue that looks like an index file? | |||
index_column = f"{column}_index" | |||
index_column = f"{col}_index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh what was this doing before these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing!
Heads up my one-FOFN-to-rule-them-all PR ended up turning into a PR that does (or at least tries to) do all the bulk ingest things. Happy to discuss in mobbing |
closing in favor of #8404 (and possible other future PRs) |
latest run of Beta User WDL with bulk ingest and no data table column names provided: https://app.terra.bio/#workspaces/gvs-dev/RSA%20-%20GVS%20Quickstart%20V2%20/job_history/79337ea3-593f-4896-b056-9f47bfd7c7c7