-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BigQuery classes [VS-971] #8375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Appear to just be moving packages and a bit of formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8375 +/- ##
================================================
Coverage ? 86.155%
Complexity ? 35517
================================================
Files ? 2194
Lines ? 166538
Branches ? 17926
================================================
Hits ? 143481
Misses ? 16674
Partials ? 6383 |
96b13ac
to
4655993
Compare
@mcovarr Does the GVS traversal artifact destined to remain in GATK depend on the |
@droazen exactly, the artifact will depend on |
4655993
to
6470418
Compare
Github actions tests reported job failures from actions build 5405305229
|
6470418
to
16fbf89
Compare
Move BigQuery classes that are only used by GVS into a
gvs
package. This should facilitate the alignment of GVS with GATK master by making it clear that these classes were created specifically for GVS and are not necessarily more generally usable in their current forms.