Rewrite haplotype construction methods in PDHapComputationEngine #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions tests reported job failures from actions build 5275320578
|
jamesemery
reviewed
Jun 16, 2023
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
davidbenjamin
force-pushed
the
db_dragen_construct_haplotype_from_events
branch
from
f215fa1
to
efa50ce
Compare
davidbenjamin
force-pushed
the
db_dragen_construct_haplotype_from_events
branch
from
efa50ce
to
fdd365b
Compare
|
Back to you, @jamesemery |
jamesemery
approved these changes
Jul 25, 2023
| // NOTE: we set this AFTER generating the event maps because hte event map code above is being generated from the ref hap so this offset will cause out of bounds errors | ||
| outHaplotype.setAlignmentStartHapwrtRef(refHap.getAlignmentStartHapwrtRef()); //TODO better logic here | ||
| result.setAlignmentStartHapwrtRef(refHap.getAlignmentStartHapwrtRef()); //TODO better logic here |
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamesemery Here's another fun one, again no change in output but significant refactoring of
constructHaplotypeFromVariantsandcreateNewPDHaplotypeFromEvents.