Add a --numeric-gt option to VariantsToTable #8219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions tests reported job failures from actions build 4246430995
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8219 +/- ##
===============================================
+ Coverage 86.654% 86.655% +0.001%
- Complexity 39165 39167 +2
===============================================
Files 2346 2346
Lines 183659 183673 +14
Branches 20151 20152 +1
===============================================
+ Hits 159147 159161 +14
Misses 17451 17451
Partials 7061 7061
|
* add an new option to VariantsToTable to allow output VCF style numeric GT fields previously it always output the actual bases of the Allele in the GT spot * resolves #8160 * updates htsjdk to 3.0.5
lbergelson
force-pushed
the
lb_variantsToTable_gt_flag
branch
from
c0ad2ce
to
157d19b
Compare
jonn-smith
requested changes
Aug 16, 2024
| for ( final String gf : genotypeFieldsToTake ) { | ||
| if ( vc.hasGenotype(sample) && vc.getGenotype(sample).hasAnyAttribute(gf) ) { | ||
| if ( vc.hasGenotype(sample) && genotype.hasAnyAttribute(gf) ) { |
There was a problem hiding this comment.
Pulling the genotype into a variable above before doing the hasGenotype check seems strange to me.
There was a problem hiding this comment.
that's.... a good point...
jamesemery
approved these changes
Aug 16, 2024
| @@ -122,6 +123,7 @@ | |||
| public final class VariantsToTable extends VariantWalker { | |||
| public final static String SPLIT_MULTI_ALLELIC_LONG_NAME = "split-multi-allelic"; | |||
| public final static String SPLIT_MULTI_ALLELIC_SHORT_NAME = "SMA"; | |||
| public static final String NUMERIC_GT_FULLNAME = "numeric-gt"; | |||
There was a problem hiding this comment.
perhaps "use-numeric-gt" to make it verbed appropriately?
|
@jonn-smith I changed the check to be equivalent but less weird looking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it always output the actual bases of the Allele in the GT spot