-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the landing page of the docs #731
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really nice! I have a couple of polishing requests.
buttons: [ | ||
{ | ||
buttonLink: 'https://app.terra.bio', | ||
buttonText: 'Joint Calling Workspace' | ||
}, | ||
{ | ||
buttonLink: 'https://app.terra.bio/#workspaces/help-gatk/GATK-Structural-Variants-Single-Sample', | ||
buttonText: 'Single-Sample Workspace' | ||
} | ||
], | ||
}, | ||
{ | ||
title: 'Scalable', | ||
Svg: require('@site/static/img/undraw_docusaurus_tree.svg').default, | ||
imageUrl: 'img/logo/terra.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logo spacing looks a little off. I'd suggest either centering the entire section and having the logo be in-line with the buttons, or make the logo larger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part splits the row into two equal-width sections, and then aligns the content on the left section to the right of the container, and the content on the right section to left of its container. Hence, they are aligned to the center of the screen. I changed this to aligning the content to the center of their container as you suggested, and also increased the max height of Terra logo from 100px to 150px. Please let me know if it looks better.
@@ -25,40 +93,111 @@ const FeatureList = [ | |||
}, | |||
{ | |||
title: 'Accurate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's limit this to one section / 3 blurbs. Can we do:
- Population-scale capabilities: used for SV discovery in flagship research studies including the Genome Aggregation Project (gnomAD) and All of Us.
- Sensitive and accurate: ensemble calling with multiple SV discovery tools combined with joint genotyping maximize power, and ML-based variant adjudication filters poor quality variants.
- Cloud-native: built for the Terra genomics platform, enabling scalability, collaboration, and reproducibility in a secure environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the text; please check. Or, you prefer one paragraph with the content you shared? We can change it to a single paragraph, but it could read like a wall of text :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also pushed a commit formatting the section as a single paragraph. Please check both commits and we can choose the one reads best.
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
…cs to a single paragraph.
This PR replaces the current landing page content with those discussed offline.
This PR also removes the empty
/docs/gs/docker.md
, a leftover from earlier PRs.