Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix Github actions out of disk error #575

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Jul 28, 2023

Github runners currently have ~15 GB disk space, and we run out of disk when building some of the base Docker images, as it will result in rebuilding many derived images. This PR adds the --prune-after-each-image to build_docker invocation to decrease disk usage. This flag was used in the Test Images Build job but missing from the Publish job, which is a bug.

The inconsequential change on the samtools-cloud/Dockerfile is to trigger building and publishing samtools-cloud docker image and all the derived images since the Publish job had failed on #574, and the images were not published.

@VJalili VJalili marked this pull request as ready for review July 28, 2023 15:17
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there any way to increase the runner disk size?

@VJalili
Copy link
Member Author

VJalili commented Jul 28, 2023

Thanks for the prompt review, @mwalker174.

Is there any way to increase the runner disk size?

There are larger runners under the paid plans; we can discuss how these can be useful moving forward as we currently have little headroom in disk size on current runners.

@VJalili VJalili merged commit e70dfbd into broadinstitute:main Jul 28, 2023
4 checks passed
@VJalili VJalili deleted the action_bug branch July 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants