Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker images build instructions to the docs #568

Merged
merged 16 commits into from
Aug 16, 2023

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Jul 12, 2023

  • Improve on gatk-sv docker images documentation;
  • Update Docusaurus to its latest version (i.e., v. 2.4.1);
  • Replace Docker-related figures with their mermaid-generated alternatives;
  • Replace the git commit history example with its equivalent mermaid alternative;

Failed Python linting errors are unrelated to this PR, and not fixing them here to avoid triggering Docker image builds which are unrelated to this PR.

@VJalili VJalili marked this pull request as ready for review August 4, 2023 15:22
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VJalili, finally we can demystify our Docker system once and for all! Overall it looks ready, I just have a few questions and suggestions.

website/docs/advanced/docker/deploy/manual.md Outdated Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Outdated Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Outdated Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Outdated Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Show resolved Hide resolved
website/docs/advanced/docker/deploy/manual.md Outdated Show resolved Hide resolved
@VJalili VJalili merged commit fc9e992 into broadinstitute:main Aug 16, 2023
3 checks passed
@VJalili VJalili deleted the docs2 branch August 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants