Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug committing changes to dockers_*.json after an image is updated #559

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Jun 27, 2023

This PR fixes two bugs:

  • The Publish action in the GitHub workflow commits changes to dockers_*.json and pushes them to the main if a variable that determines whether the file is updated or not is set to True. With recent changes to Github actions, the method we previously used to set this variable is deprecated; hence the variable is not correctly set, resulting in not committing the changed dockers_*.json files to main. This issue is fixed in this PR.
  • Azure container registry was not passed as a target repo; this bug is fixed in this PR.
  • Due to the above bugs, the dockers_*.json was not updated with the latest image builds. The only impact image in the recently merged PRs is sv-pipeline; hence this PR adds the build and pushed the image to the dockers_*.json.

@VJalili VJalili requested a review from mwalker174 June 27, 2023 20:00
@VJalili VJalili marked this pull request as ready for review June 27, 2023 20:01
@VJalili VJalili merged commit 4f29bd5 into broadinstitute:main Jun 27, 2023
4 checks passed
@VJalili VJalili deleted the github_workflow branch June 27, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants