fix: passing body for graphql requests generated from aws-appsync-simulator

[sc0ttdav3y]

Hi,

I'm running a local version of AppSync (via servereless-offline)+ API Gateway (via this package) + Bref:

[ Client ] ---> [ AppSync ] ---> [ HTTP Resolver ] ---> [ API Gateway] ---> [ Bref ]

I was finding all of my GraphQL queries and mutations were missing the body part of the request. I looked into it and found local-api-gateway was suppressing the body of the request.

I have removed that conditional in this PR to pass the body whenever it's available, and all is working for my use case now.

I get the intent of the code, and I suspect it's not working because the payload, at least in my case, has method in request.requestContext.method, and not request.method. But I think it's not terrible to simplify things and just pass body if it's supplied, especially given the aims of this project to be minimally useful.

I also added a tidy on L64 to cast request.ip as a string, because the Typescript indicates request.ip is string|null while the AWS payload must be a string.

Note I tried to spin up the tests and contribute a unit test, but I couldn't work out the dev steps to get them going. If you want me to work on some tests, give me some hints on how to get started and I'd be happy to do so.

Thanks, Scott

[mnapoli]

Thanks, on paper that makes sense.

However the tests are failing, can you fix those?

To run the tests you need to run npm run test (run npm i before ofc).

[sc0ttdav3y]

My missing knowledge in running the tests was having to set the environment variable TARGET="localhost:9000" beforehand. With that done I've fixed the failing test.

[mnapoli]

Oh cool, might be worth adding to the docs or even the npm run test script, but let's not block this PR 👍

[sc0ttdav3y]

A good medal to you @mnapoli 🏅 — I can confirm this fix is working well via the new docker image, and many thanks for the work you do on this project and Bref generally.

[mnapoli]

Awesome! btw I'd love to learn more how you use Bref, I've never seen that architecture done with Bref before. I posted a link to my calendar here, feel free to book some time if you want: https://twitter.com/matthieunapoli/status/1849780007998259673