Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setupHTTPCredentials in fetchConfiguration #1432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add setupHTTPCredentials in fetchConfiguration #1432

wants to merge 1 commit into from

Conversation

KunJeongPark
Copy link
Contributor

Summary of changes

  • Make sure setupHTTPCredentials is called in fetchConfiguration used in sendQueuedAnlayticsEvents.

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark KunJeongPark requested a review from a team as a code owner October 8, 2024 16:45
@KunJeongPark KunJeongPark changed the title add setupHTTPCredentials in fetchConfiguration Add setupHTTPCredentials in fetchConfiguration Oct 8, 2024
agedd
agedd approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! curious if there is reason we're making this change now 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agedd agedd agedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KunJeongPark @agedd