-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPEN DEV] Add Custom Authorization Setting #1426
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # Demo/Application/Base/Settings/BraintreeDemoSettings.swift
@@ -35,28 +35,19 @@ class BraintreeDemoSettings: NSObject { | |||
|
|||
static var currentEnvironmentName: String { | |||
switch currentEnvironment { | |||
case .sandbox: | |||
case .sandbox, .custom: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I have this set up to hit sandbox since that seemed like what we would hit the most. Could also consider building logic to parse the first part of the environment from the tokenization key if folks think we may also want to use this for prod testing. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting on the Braintree Gateway side stage routes through sandbox as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🙌🏽
Summary of changes
sandbox_jy4fvpfg_v7x2rb226dx4pr7b
and the PayPal Vault flow, this is routed to hit stage and you should see the stage URL in the demo app.Checklist
[ ] Added a changelog entryAuthors