Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPEN DEV] Add Custom Authorization Setting #1426

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Allow us to pass custom tokenization keys in sandbox if needed. This would allow us to do quick clarity checks on flows that may not be set up for our sample merchant server. It could also allow us to test flows on stage (that are routed through sandbox on the gateway side) for things like app switch before it is rolled out. We weren't using the previous custom setup at all, so this gives us a bit more use.
  • You can test this by using your own tokenization key or using sandbox_jy4fvpfg_v7x2rb226dx4pr7b and the PayPal Vault flow, this is routed to hit stage and you should see the stage URL in the demo app.

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 4, 2024 16:28
@@ -35,28 +35,19 @@ class BraintreeDemoSettings: NSObject {

static var currentEnvironmentName: String {
switch currentEnvironment {
case .sandbox:
case .sandbox, .custom:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now I have this set up to hit sandbox since that seemed like what we would hit the most. Could also consider building logic to parse the first part of the environment from the tokenization key if folks think we may also want to use this for prod testing. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting on the Braintree Gateway side stage routes through sandbox as well.

Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants