[DO NOT REVIEW] Merge RBA Metadata feature branch
#1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix constraints warning by adding leading and trailing constraints for nested stackViews * remove print statement
* Update to include total_amount property * Update demo and test * Update comment * Change productAmount to productPrice * Revert "Change productAmount to productPrice" This reverts commit ea65894. * Group totalAmount property closer with other required properties * Group totalAmount property with other required props * PR comment
* Working demo values for RBA * PR feedback startDate format docstring * jax PR comment * Jax Pr feedback 2 --------- Co-authored-by: Victoria Park <[email protected]>
# Conflicts: # CHANGELOG.md # Demo/Application/Features/PayPalWebCheckoutViewController.swift
* Update to include production tokenization key * Use current production token * Add TODO
# Conflicts: # CHANGELOG.md
# Conflicts: # Demo/Application/Features/PayPalWebCheckoutViewController.swift
* End to end testing revealed that there are cases where billing_frequency and billing_frequency_unit are not required for unscheduled cases for RBA metadata - updated and tested that these fields can be omitted without error when the recurringBillingPlanType is .unscheduled and the pricingModel is .autoReload per the test case * Updated docstrings
scannillo
reviewed
Oct 1, 2024
| @@ -182,10 +182,21 @@ class ContainmentViewController: UIViewController { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Remove this once ModXO goes GA | |||
There was a problem hiding this comment.
We should be able to revert this. ModXO is live
There was a problem hiding this comment.
Not a blocker for this merge though!
scannillo
approved these changes
Oct 1, 2024
jaxdesmarais
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors