Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RiskCorrelationID to BTPayPalVaultEditRequest #1397

Closed

Conversation

KunJeongPark
Copy link
Contributor

@KunJeongPark KunJeongPark commented Aug 26, 2024

Summary of changes

  • Add RiskCorrelationID to BTPayPalVaultEditRequest
  • Add docStrings for RiskCorrelationID

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark KunJeongPark requested a review from a team as a code owner August 26, 2024 16:26
Comment on lines 15 to +16
/// merchantAccountID: optional ID of the merchant account; if one is not provided the default will be used
/// riskCorrelationID: optional ID passed in by merchant to track errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// merchantAccountID: optional ID of the merchant account; if one is not provided the default will be used
/// riskCorrelationID: optional ID passed in by merchant to track errors
/// merchantAccountID: Optional: ID of the merchant account; if one is not provided the default will be used
/// riskCorrelationID: Optional: Required only for the error handling flow to retry failed attempts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jax, I will include this as we get updated req's on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've decided to move forward with this for now and if we get feedback that it's confusing can make updates in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update to the suggestion above and we should be all set for this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am closing this PR with updated req's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants