Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Demo ViewController file structure #1110

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Conversation

scannillo
Copy link
Contributor

Summary of changes

  • Remove directory nesting each feature view controller
  • Drop BraintreeDemo naming prefix from each demo view controller

Screenshots

Before After
Screenshot 2023-10-05 at 4 42 15 PM Screenshot 2023-10-05 at 4 47 09 PM

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner October 5, 2023 21:55
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -0,0 +1,14 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry yes - lots of merge conflicts earlier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was my bad - I probably should have merged mine in last since it was also nested in this structure. 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, that package.resolves is always a PITA!

@scannillo scannillo merged commit e32a43a into main Oct 10, 2023
6 checks passed
@scannillo scannillo deleted the cleanup-demo-files branch October 10, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants