Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Duplicate Tokenize Call in NXO Demo #1109

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Remove Duplicate Tokenize Call in NXO Demo #1109

merged 1 commit into from
Oct 6, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • We were calling tokenize twice in tappedVaultCheckout method of the BraintreeDemoPayPalNativeCheckoutViewController

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 5, 2023 16:38
scannillo
scannillo approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in another PR we can update our demo to use async-await methods

@jaxdesmarais jaxdesmarais merged commit f24b3c5 into main Oct 6, 2023
5 of 6 checks passed
@jaxdesmarais jaxdesmarais deleted the remove-duplicate-tokenize-nxo-demo branch October 6, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sarahkoop