Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate PayPal ViewControllers #1102

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Consolidate PayPal ViewControllers #1102

merged 4 commits into from
Sep 26, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Consolidate PayPal Checkout, Vault and Pay Later ViewControllers into a single ViewController with all 3 buttons
  • Update settings drop down to PayPal - Web Checkout

simulator_screenshot_91388B18-3BD4-40B4-97FE-77F0057953E8

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner September 22, 2023 15:46
scannillo
scannillo approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@jaxdesmarais jaxdesmarais merged commit 77ca7d8 into main Sep 26, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the consolidate-paypal-viewcontrollers branch September 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sshropshire