Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug where fetchPaymentMethodNonces Return Incorrect Type #1100

Merged
merged 14 commits into from
Sep 29, 2023
Merged

Fix Bug where fetchPaymentMethodNonces Return Incorrect Type #1100

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
28e36d2
extract type from nonce
jaxdesmarais Sep 14, 2023
9319995
add unit test case to ensure we get the correct type from nonce in fe…
jaxdesmarais Sep 14, 2023
a9a4057
add CHANGELOG entry
jaxdesmarais Sep 14, 2023
c821e2e
WIP - add card type handling
jaxdesmarais Sep 14, 2023
a086353
add parser tests
jaxdesmarais Sep 18, 2023
6cbd5ed
remove test not actually for parser
jaxdesmarais Sep 18, 2023
1d58414
add next major version note
jaxdesmarais Sep 22, 2023
0310ecb
add logic for different types
jaxdesmarais Sep 22, 2023
58da865
move tests for parser into single file
jaxdesmarais Sep 25, 2023
9cee196
add note to docstring
jaxdesmarais Sep 25, 2023
4b89b34
Update Braintree.xcodeproj/project.pbxproj
jaxdesmarais Sep 25, 2023
c36f238
update BTAPIClient_Tests
jaxdesmarais Sep 25, 2023
388c36a
move tests into BTPayPalAccountNonce_Tests file
jaxdesmarais Sep 25, 2023
bf0a676
Update Braintree.xcodeproj/project.pbxproj
jaxdesmarais Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Braintree iOS SDK Release Notes

## unreleased
* BraintreeCore
* Fix bug where `type` was always returned as `Unknown` in `fetchPaymentMethodNonces` (fixes #1099)

## 6.6.0 (2023-08-22)
* BraintreePayPalNativeCheckout
* Update PayPalCheckout from 1.0.0 to 1.1.0.
Expand Down
2 changes: 1 addition & 1 deletion Sources/BraintreeCore/BTPaymentMethodNonceParser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ import Foundation
if json?["nonce"].isString != false {
return BTPaymentMethodNonce(
nonce: json?["nonce"].asString() ?? "",
type: "Unknown",
type: json?["type"].asString() ?? "Unknown",
isDefault: json?["default"].isTrue ?? false
)
}
Expand Down
2 changes: 2 additions & 0 deletions UnitTests/BraintreeCoreTests/BTAPIClient_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,11 @@ class BTAPIClient_Tests: XCTestCase {

let firstNonce = paymentMethodNonces[0];
XCTAssertEqual(firstNonce.nonce, "fake-nonce1")
XCTAssertEqual(firstNonce.type, "CreditCard")

let secondNonce = paymentMethodNonces[1]
XCTAssertEqual(secondNonce.nonce, "fake-nonce2")
XCTAssertEqual(secondNonce.type, "PayPalAccount")

expectation.fulfill()
}
Expand Down
Loading