Update with bibfilter: add a new bibtex template #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow search for publication year, keyword, Improve the search filters example: [bibfilter file=bib.bib group=year group_order=desc allow=inproceedings,article,book,inbook,incollection,techreport,mastersthesis,phdthesis,unpublished author=Nguyen|Gimel'farb|Delmas sortauthors=1 keyword="3D content,Web browsers,World Wide Web,Internet,Online front-ends,Stereo image,3D image,3D reconstruction,Image analysis,Vision,Binocular,Stereopsis,Calibration" ]
| @@ -125,7 +161,7 @@ class Papercite { | |||
| function getCached($url, $timeout = 3600) { | |||
| // check if cached file exists | |||
| $name = strtolower(preg_replace("@[/:]@","_",$url)); | |||
| $dir = plugins_dir_path(__FILE__) . "/papercite/cache"; | |||
There was a problem hiding this comment.
You should not use WP_PLUGIN_DIR (see http://codex.wordpress.org/Determining_Plugin_and_Content_Directories)
|
There are several problems with the pull request, but I guess most of them is because you modified old code (in the repository, there are changes that are not yet in the papercite releases). You should do the following :
thanks - if you need help, please email. |
This reverts commit 8afa815.
|
Hi, I will look at this soon, thanks. |
|
See pull request #101 comment - but I keep the idea of more filtering, and will merge some part of your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow search for publication year, keyword,
Improve the search filters
example:
[bibfilter
file=bib.bib
group=year
group_order=desc
allow=inproceedings,article,book,inbook,incollection,techreport,mastersthesis,phdthesis,unpublished
author=Nguyen|Gimel'farb|Delmas
sortauthors=1
keyword="3D content,Web browsers,World Wide Web,Internet,Online front-ends,Stereo image,3D image,3D reconstruction,Image analysis,Vision,Binocular,Stereopsis,Calibration"
]