Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 cluster creation issue in testsys #954

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zongzhidanielhu
Copy link

@zongzhidanielhu zongzhidanielhu commented Dec 2, 2024

Issue number:
ipv6 variants always have a ipFamily=ipv4

Description of changes:
changed the way of create cluster so that ipv6 has ipFamily=ipv6, ipv4 has ipFamily=ipv4

Testing done:

  1. after codebase changed, but new docker image for bottlerocket-test-system
  2. push image into ECR
  3. trigger the changes in BoB, the applied variant is aws-k8s-1.24
  4. Checked cluster status in cloudFormation, the aforementioned issue has been solved

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zongzhidanielhu zongzhidanielhu changed the title Added ipFamily conditions ipv6 cluster creation issue in testsys Dec 11, 2024
@zongzhidanielhu zongzhidanielhu marked this pull request as ready for review December 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants