-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kubernetes device-ownership setting #329
base: develop
Are you sure you want to change the base?
Conversation
git = "https://github.com/bottlerocket-os/bottlerocket-settings-sdk" | ||
tag = "bottlerocket-settings-models-v0.6.0" | ||
git = "https://github.com/vigh-m/bottlerocket-settings-sdk" | ||
tag = "test-1" | ||
version = "0.6.0" | ||
|
||
[workspace.dependencies.bottlerocket-settings-models] | ||
git = "https://github.com/bottlerocket-os/bottlerocket-settings-sdk" | ||
tag = "bottlerocket-settings-models-v0.6.0" | ||
git = "https://github.com/vigh-m/bottlerocket-settings-sdk" | ||
tag = "test-1" | ||
version = "0.6.0" | ||
|
||
[workspace.dependencies.bottlerocket-settings-plugin] | ||
git = "https://github.com/bottlerocket-os/bottlerocket-settings-sdk" | ||
tag = "bottlerocket-settings-plugin-v0.1.0" | ||
git = "https://github.com/vigh-m/bottlerocket-settings-sdk" | ||
tag = "test-1" | ||
version = "0.1.0" | ||
|
||
[workspace.dependencies.settings-extension-oci-defaults] | ||
git = "https://github.com/bottlerocket-os/bottlerocket-settings-sdk" | ||
tag = "bottlerocket-settings-models-v0.6.0" | ||
git = "https://github.com/vigh-m/bottlerocket-settings-sdk" | ||
tag = "test-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have not yet merged the sdk PR. Could you change the status of this core-kit PR to draft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I had these changes in a separate commit to make it easy to remove them later. I'll move to a draft as well.
# "https://github.com/bottlerocket-os/bottlerocket-settings-sdk", | ||
"https://github.com/vigh-m/bottlerocket-settings-sdk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also be updated once sdk change is merged.
Description of changes:
packages/containerd/containerd-config-toml_k8s_containerd_sock
to support the new setting being added in feat: Add kubernetes device ownership bottlerocket-settings-sdk#69. This is to support the same setting in the containerd CRI plugin as described hereTesting done:
The setting shows up as expected in an AMI built using this
settings-sdk
Changing the setting works as defined:
The setting has the desired effect on device ownership
true
:false
:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.