Fix source groups #271
Open
Fix source groups #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`source-groups` should only be used within `packages/**/Cargo.toml`, in any other place it doesn't have any effect Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
`early-boot-config` depends on `imdsclient` and `apiclient`, and should be re-build whenever either of them changes Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
bcressey
reviewed
Nov 19, 2024
| @@ -10,6 +10,8 @@ path = "../packages.rs" | |||
|
|
|||
| [package.metadata.build-package] | |||
| source-groups = [ | |||
| "api", | |||
| "imdsclient", | |||
There was a problem hiding this comment.
Let's just list early-boot-config here instead of the individual subdirectories.
Appears to be missing constants, generate-readme, imdsclient, ...
The brute force way to generate this list would be:
- copy the sources tree to another location
- delete everything from the sources tree that isn't a directory in
source-groups - trim the workspace
Cargo.tomland regenerateCargo.lock - see if the package still builds
static-pods and netdog probably also need to be revisited with an eye to completing the dependency picture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
early-boot-configwas missingapiandimdsclientfrom itssource-groupdependencies, so changes to eitherapiclientorimdsclientdidn't trigger a rebuild ofearly-boot-config.pluto'sCargo.tomlincludedsource-groupsby mistake, and it doesn't have any effect.Testing done:
After this change, I confirmed that
early-boot-configwas re-compiled whenever I changedapiclientorimdsclient(even by justtouching the files). Before this change,touching didn't trigger a rebuild.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.