Link Host certificates if available in Control Container #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
reviewed
Dec 23, 2024
| declare -r HOST_CERTS="/.bottlerocket/certs" | ||
|
|
||
| # Link host certs if present into container & run update-ca-trust | ||
| if [ -e "${HOST_CERTS}" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ -e "${HOST_CERTS}" ]; then | |
| if [[ -d "${HOST_CERTS}" ]]; then |
| @@ -6,6 +6,16 @@ declare -r PERSISTENT_STORAGE_BASE_DIR="/.bottlerocket/host-containers/current" | |||
| declare -r USER_DATA="${PERSISTENT_STORAGE_BASE_DIR}/user-data" | |||
| declare -r SSM_AGENT_PERSISTENT_STATE_DIR="${PERSISTENT_STORAGE_BASE_DIR}/ssm" | |||
| declare -r SSM_AGENT_LOCAL_STATE_DIR="/var/lib/amazon/ssm" | |||
| declare -r HOST_CERTS="/.bottlerocket/certs" | |||
|
|
|||
| # Link host certs if present into container & run update-ca-trust | |||
There was a problem hiding this comment.
Can we move this block to after the function declarations, or make it a function itself, to remain consistent with the rest of the script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change links host certificates if it has been updated on the Bottlerocket host. It checks if the path /.bottlerocket/certs exists, if so links the certs to the ca-trust source.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.