Add flags to borg extract Command (#8564) #8575
Conversation
|
BTW, don't add |
|
Got it, I’ll ensure temporary files are omitted moving forward. Could you please share more details or context about the errors above? This would help me better understand and address the issue. |
|
The failing |
|
Changed the code and now everything seems to be running as expected at my end and borg extract finishes with rc 0. Just wanted to ask if the errors could be because of me working on MacOS and not having pyfuse3? |
|
The errors are unrelated to macOS and not having pyfuse3 - I also work on a macbook. If one want to test or work on the mount / FUSE code in borg, one would need macFUSE installed and use llfuse (not pyfuse3). But this is not required here. |
|
@ThomasWaldmann Please review. |
|
Can you rather rebase on master please than merge master in here? |
alighazi288
force-pushed
the
fix-issue-8564
branch
5 times, most recently
from
5b617be to
c9527a4
Compare
…e expected flags.
… exclusion flags - Verified that excluded items are not listed during non-dry-run extraction.
alighazi288
force-pushed
the
fix-issue-8564
branch
from
c9527a4 to
edd3a50
Compare
Ensure preloading only for included items. large amount of changes due to rebase mishap
|
@ThomasWaldmann I wanted to let you know that there appears to be a large number of changes in this pull request because I encountered some issues while attempting to rebase on master. I apologize for any confusion this may have caused. This is the most recent commit: 8404970 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8575 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 74 74
Lines 13311 13317 +6
Branches 1960 1961 +1
=======================================
+ Hits 10894 10899 +5
Misses 1755 1755
- Partials 662 663 +1 ☔ View full report in Codecov by Sentry. |
| @@ -66,7 +67,10 @@ def do_extract(self, args, repository, manifest, archive): | |||
|
|
|||
| is_matched = matcher.match(orig_path) | |||
| log_prefix = "+" if is_matched else "-" | |||
| logging.getLogger("borg.output.list").info(f"{log_prefix} {remove_surrogates(item.path)}") | |||
|
|
|||
| # Conditionally log based on the output_list flag | |||
There was a problem hiding this comment.
please avoid such comments. it does not add any information that is not obvious from the next 2 lines anway.
There was a problem hiding this comment.
Understood. Would you like me to remove it and commit again?
alighazi288
changed the title
Summary
This pull request addresses the issue with the
borg extractcommand not displaying the flags as seen in other commands eg.borg createandborg recreate.