Remove unneeded casts #880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AreaZR
force-pushed
the
cast
branch
5 times, most recently
from
d2a27f9
to
dcc2447
Compare
AreaZR
force-pushed
the
cast
branch
2 times, most recently
from
e1ffffc
to
5fe2933
Compare
|
Any update on this? @mborland |
I don't think this passes the litmus test I have given you for inclusion. You also just pushed updates 10 mins ago? |
jzmaddock
reviewed
Dec 1, 2022
jzmaddock
reviewed
Dec 1, 2022
|
@mborland Addressed! |
AreaZR
force-pushed
the
cast
branch
8 times, most recently
from
a878ba7
to
80eabf8
Compare
AreaZR
force-pushed
the
cast
branch
2 times, most recently
from
67cb716
to
1d51061
Compare
Most of these casts are redundant, and automatically dealt with by either the C++/C standard, or operations done onto said numbers, such as & 1 operation making casts to int pointless.
jzmaddock
added a commit
that referenced
this pull request
Oct 17, 2023
Add tests and make sure everything is covered, and fix resulting errors.
|
Closing in favour of #1039. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these casts are redundant, and automatically dealt with by either the C++/C standard, or operations done onto said numbers, such as & 1 operation making casts to int pointless.