-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost PFR as implicit fallback #266
base: develop
Are you sure you want to change the base?
Conversation
…xed typo in the doc
85da528
to
cd54084
Compare
f76d203
to
f11cca0
Compare
f11cca0
to
aed0503
Compare
24fe131
to
4686805
Compare
@djowel, @daminetreg , @Kojoley I'm ready to show this PR. |
@djowel Hello, are we going on? |
Wow awesome that's terrific. I missed your comment from 29th January. I will do my best to review and try it out this Friday. |
@daminetreg Cool! |
@daminetreg Hi! I want to inform that I may be unavailable a month later for some time. Can we do something with this PR right now, or we will just postpone it for some time? How is your review going on, is there any trouble or just not enough time for it? Can I help you with something? Maybe I should reduce this PR throwing away the implicit reflection? We would merge the explicit one pretty fast, and then leisurely continue working on huge implicit reflection having already released the first PFR integration. |
Hi @denzor200 , sorry for the delay I couldn't try yet but I will do my best to give my early feedback this week still. I think it's a very awesome feature, so we should not wait too long for merging. I apologies for my bandwidth here. |
Any updates on this? |
@xR3b0rn everything ready from my side, waiting for review. As I informed above, I was unavailable for some months. But right now I'm available every day and can react to review pretty fast. |
#231
This PR suggests to use PFR in the Fusion like implicit fallback. It means that Fusion will try using PFR for types that isn't a Fusion Sequence.
This is an optional functional enables by inclusion of special header (
adapted/boost_pfr.hpp
, for example), or it enables by inclusion of justadapted.hpp
. If you don't need this, just don't include special header, or disable PFR using special macro(BOOST_PFR_ENABLED
, for example ).If you need to use PFR, but you don't want to use it like implicit fallback, you may disable implicit reflection and use explicit instead. Explicit reflection requires from user to specify all reflectable types manually using one of the suggested macroes.
Explicit reflection is provided by the header
adapted/boost_pfr_explicit.hpp
.It's able to play with this PR here: https://godbolt.org/z/vMMf8GTE4