Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt bimaps::relation::structured_pair, container::detail::pair, and compressed_pair #196

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CromwellEnage
Copy link

Recognize boost::bimaps::relation::structured_pair, boost::container::detail::pair, and boost::compressed_pair as Fusion sequences.

… compressed_pair

Recognize boost::bimaps::relation::structured_pair, boost::container::detail::pair, and boost::compressed_pair as Fusion sequences.
Added documentation for newly adapted Fusion sequences bimaps::relation::structured_pair, compressed_pair, and container::detail::pair.
@djowel
Copy link
Collaborator

djowel commented Oct 6, 2020

Awesome!

@djowel
Copy link
Collaborator

djowel commented Oct 6, 2020

I suppose it makes sense to merge this. I have a request though: would you take care of support related issues related to these additions?

Distributed under the Boost Software License, Version 1.0.
(See accompanying file LICENSE_1_0.txt or copy at
http://www.boost.org/LICENSE_1_0.txt)
============================================================================*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superfluous edit?

#include <boost/fusion/adapted/adt.hpp>
#include <boost/fusion/adapted/array.hpp>
#include <boost/fusion/adapted/boost_array.hpp>
#include <boost/fusion/adapted/boost_tuple.hpp>
#include <boost/fusion/adapted/mpl.hpp>
#include <boost/fusion/adapted/std_pair.hpp>
#include <boost/fusion/adapted/boost_bimap_pair.hpp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it some more, perhaps it's good to have a preprocessor define for bringing these in? Perhaps initially undefined. E.g. BOOST_FUSION_ADAPT_BIMAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants