Some modifications to the devise login tracker gem #1
+11
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_id, even if the model wasn't User. It now creates via the association, which is always 'logins', so we use logins.create & etc
…evise is workign with more than one model. This resulted in an error because warden.session[etc] would try to get the session hash for the default model, which might not be the one you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've been using your gem and I've had to fix some issues that occur if you're using a model that isn't User, and possibly many Devised models in one app. In my case I have a User model and an Admin model so that I can have different authentication rules for different classes of user. It was always trying to use User, even if the login was from Admin.
One of the changes you probably won't want to include. I've change the migration so that it uses the Postgresql type inet for storing ip addresses, hence t.inet in the migration. This is special for my use, so I'm going to change the gem to be pg-devise-login-tracker so I can publish it on RubyGems and pull it into the projects I'm working on right now. I get problems with gems loaded directly from GitHub when I'm installing in the cloud.
Thanks for your work on this.
John Small