Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template to avoid default regex self-match when copy-pasted to merge commit message #468

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

fmigneault
Copy link
Collaborator

Overview

Update PR template to avoid default regex self-match when copy-pasted to merge commit message.

Use roundabout comment description to avoid matching the regex.

Changes

Non-breaking changes

  • CI maintenance, PR template

Breaking changes

  • n/a

Related Issue / Discussion

  • Fix PR not triggering CI.

CI Operations

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

@github-actions github-actions bot added the ci/operations Continuous Integration components label Sep 9, 2024
@fmigneault fmigneault self-assigned this Sep 9, 2024
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of [skip ci] we should use [<cmd> = skip ci] in the commit message?

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2790/
ResultSUCCESS

BIRDHOUSE_DEPLOY_BRANCH : patch-pr-template
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-216.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1679/

NOTEBOOK TEST RESULTS
    
[2024-09-09T17:43:12.805Z] ============================= test session starts ==============================
[2024-09-09T17:43:12.805Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-09-09T17:43:12.805Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-09-09T17:43:12.805Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-09-09T17:43:12.805Z] collected 308 items
[2024-09-09T17:43:12.805Z] 
[2024-09-09T17:43:22.917Z] notebooks-auth/geoserver.ipynb ..................                        [  5%]
[2024-09-09T17:44:29.219Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [  9%]
[2024-09-09T17:44:34.933Z] notebooks-auth/test_thredds.ipynb ...........                            [ 12%]
[2024-09-09T17:45:24.098Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 14%]
[2024-09-09T17:45:34.356Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 16%]
[2024-09-09T17:45:42.768Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 18%]
[2024-09-09T17:45:56.536Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 21%]
[2024-09-09T17:53:15.385Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 25%]
[2024-09-09T17:53:15.385Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 25%]
[2024-09-09T17:53:18.157Z] ...............                                                          [ 30%]
[2024-09-09T17:53:26.523Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 32%]
[2024-09-09T17:53:33.190Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 34%]
[2024-09-09T17:53:47.974Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 36%]
[2024-09-09T17:53:59.592Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 38%]
[2024-09-09T17:54:04.264Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 39%]
[2024-09-09T17:57:43.857Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2024-09-09T17:58:50.610Z] .............                                                            [ 49%]
[2024-09-09T17:58:53.055Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 50%]
[2024-09-09T17:58:54.966Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 52%]
[2024-09-09T17:59:10.756Z] .................                                                        [ 58%]
[2024-09-09T17:59:18.599Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 60%]
[2024-09-09T17:59:19.983Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 60%]
[2024-09-09T17:59:37.255Z] .........                                                                [ 63%]
[2024-09-09T17:59:47.247Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 67%]
[2024-09-09T17:59:56.991Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 69%]
[2024-09-09T17:59:57.950Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 69%]
[2024-09-09T18:00:01.029Z] .....                                                                    [ 71%]
[2024-09-09T18:00:23.049Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 71%]
[2024-09-09T18:00:41.140Z] ............                                                             [ 75%]
[2024-09-09T18:00:56.052Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 75%]
[2024-09-09T18:01:18.129Z] .....s.                                                                  [ 77%]
[2024-09-09T18:01:24.731Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 78%]
[2024-09-09T18:01:42.948Z] ..                                                                       [ 78%]
[2024-09-09T18:01:49.542Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 79%]
[2024-09-09T18:02:52.873Z] .........                                                                [ 82%]
[2024-09-09T18:03:02.871Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 82%]
[2024-09-09T18:08:17.914Z] ....                                                                     [ 83%]
[2024-09-09T18:08:17.915Z] PAVICS-landing-master/content/notebooks/hydrology/PAVICStutorial_Hydrology-01_Intro.ipynb . [ 84%]
[2024-09-09T18:08:19.131Z] ....                                                                     [ 85%]
[2024-09-09T18:08:23.321Z] PAVICS-landing-master/content/notebooks/hydrology/PAVICStutorial_Hydrology-02_Calibration.ipynb . [ 85%]
[2024-09-09T18:08:28.914Z] .....                                                                    [ 87%]
[2024-09-09T18:08:33.116Z] PAVICS-landing-master/content/notebooks/hydrology/PAVICStutorial_Hydrology-03_Watershed_properties.ipynb . [ 87%]
[2024-09-09T18:08:47.522Z] .............                                                            [ 91%]
[2024-09-09T18:08:51.740Z] PAVICS-landing-master/content/notebooks/hydrology/PAVICStutorial_Hydrology-04_Time_series_analysis.ipynb . [ 92%]
[2024-09-09T18:08:53.474Z] ......                                                                   [ 94%]
[2024-09-09T18:08:55.957Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2024-09-09T18:11:45.113Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-09-09T18:11:45.114Z] 
[2024-09-09T18:11:45.114Z] =============================== warnings summary ===============================
    
  

@fmigneault
Copy link
Collaborator Author

@tlvu
No. It remains [skip ci], but if we leave [skip ci] as is in the PR template, this is what caused the regex to match and therefore skip the PR trigger.

@fmigneault fmigneault merged commit a38b4c5 into master Sep 9, 2024
4 of 5 checks passed
@fmigneault fmigneault deleted the patch-pr-template branch September 9, 2024 22:51
fmigneault added a commit that referenced this pull request Sep 16, 2024
## Overview

Same as #468, but for the contributing docs.

## Changes

**Non-breaking changes**
- n/a

**Breaking changes**
- n/a

## Related Issue / Discussion

- #468


## CI Operations


birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/operations Continuous Integration components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants