Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plotter argument to PhenotypicPhasePlaneResult.plot() #289

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

djinnome
Copy link

Solving issue #288

Thanks to @jafemm for discovering this issue

Solving  issue biosustain#288

Thanks to @jafemm for discovering this issue
@carrascomj carrascomj self-requested a review November 25, 2021 07:57
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #289 (e7f5859) into devel (8b1adb7) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #289      +/-   ##
==========================================
- Coverage   63.35%   63.18%   -0.18%     
==========================================
  Files          58       58              
  Lines        5786     5786              
  Branches      997      997              
==========================================
- Hits         3666     3656      -10     
- Misses       1902     1913      +11     
+ Partials      218      217       -1     
Impacted Files Coverage Δ
...ain_design/pathway_prediction/pathway_predictor.py 74.23% <0.00%> (ø)
cameo/models/webmodels.py 56.81% <0.00%> (-7.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1adb7...e7f5859. Read the comment docs.

Copy link
Member

@carrascomj carrascomj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

The python 3.6 tests are failing but that does not have anything to do with this PR.

@Rodriguez0101
Copy link

¿Cómo hago para visualizar en 3D una variable de tipo cameo.flux_analysis.analysis.PhenotypicPhasePlaneResult?
result_3D.plot(plotter) #Este es el código que use

AttributeError: 'DataFrame' object has no attribute 'as_matrix'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants