parsnp: add aarch64/arm64 builds #51064
Conversation
martin-g
added
aarch64
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/parsnp/build.sh (2)
18-18: Improved build efficiency with parallel compilation.Using
${CPU_COUNT}for parallel builds is an excellent optimization. This change can significantly speed up the compilation process on multi-core systems.Consider adding a fallback in case
${CPU_COUNT}is not set:-make -j ${CPU_COUNT} +make -j ${CPU_COUNT:-1}This ensures the build works even if
${CPU_COUNT}is not defined, defaulting to a single core.
29-29: Consistent parallel build optimization for main application.Excellent addition of parallel compilation for the main application build, consistent with the muscle library build optimization.
As suggested earlier, consider adding a fallback for
${CPU_COUNT}:-make -j ${CPU_COUNT} LDADD="$LDADD -lMUSCLE-3.7" +make -j ${CPU_COUNT:-1} LDADD="$LDADD -lMUSCLE-3.7"This ensures the build works even if
${CPU_COUNT}is not defined, defaulting to a single core.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/parsnp/build.sh (3 hunks)
- recipes/parsnp/meta.yaml (2 hunks)
🔇 Additional comments (6)
recipes/parsnp/build.sh (3)
3-4: Improved script robustness and debugging.The addition of
set -xeis a good practice. It enables command echoing (-x) for easier debugging and ensures the script exits immediately if any command fails (-e), preventing cascading errors.
Line range hint
35-43: Comprehensive file installation.Good job ensuring all necessary files are copied to the installation directory. This includes the main executable, Python scripts, and additional resources.
The creation of a
$PREFIX/bin/bindirectory is unusual. Please verify if this structure is intentional and required for the package to function correctly. Run the following script to check the final directory structure:Review the output to ensure the directory structure is correct and all files are in their intended locations.
Line range hint
31-33: Cleanup of build artifacts.Good practice to remove unnecessary directories after installation, helping to keep the package size minimal.
Please verify that removing these directories doesn't impact the package functionality. Run the following script to check for any remaining references to these directories:
If the script returns any results, we may need to adjust the cleanup or update other parts of the package.
✅ Verification successful
Cleanup Verification Successful
The removal of the directories
muscle/libMUSCLE,muscle/autom4te.cache, andmuscle/m4does not impact the package functionality.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining references to removed directories # Test: Search for references to removed directories rg -i 'muscle/libMUSCLE|muscle/autom4te.cache|muscle/m4' --type sh --type yamlLength of output: 219
recipes/parsnp/meta.yaml (3)
12-12: LGTM: Build number increment is correct.Incrementing the build number from 0 to 1 is appropriate when making changes to the package without altering the version. This change aligns with the PR objective of adding new architecture builds.
Line range hint
1-48: Verify architecture-specific requirements for new platforms.The package version, source URL, and general requirements appear correct. However, given the addition of 'linux-aarch64' and 'osx-arm64' platforms, it's important to verify if any architecture-specific requirements or build flags are needed.
Could you confirm if any additional requirements or build flags are necessary for the 'linux-aarch64' and 'osx-arm64' architectures? This might include architecture-specific compiler flags or dependencies.
To assist in this verification, let's check for any existing architecture-specific patterns in the recipe:
#!/bin/bash # Description: Check for architecture-specific patterns in the recipe # Test: Search for architecture-specific selectors or flags rg --type yaml '\[aarch64\]|\[arm64\]|\[osx-arm64\]' recipes/parsnp/meta.yaml
50-53: Clarification needed on 'additional-platforms' usage.The addition of 'linux-aarch64' and 'osx-arm64' platforms aligns with the PR objective. However, 'additional-platforms' is not a standard Conda recipe field.
Could you clarify the purpose and effect of using 'additional-platforms' in the 'extra' section? Is this a Bioconda-specific feature?
To verify if this is a common practice in Bioconda recipes, let's run the following script:
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
force-pushed
the
aarch64-parsnp
branch
from
8cbcafe
to
b7c9d65
Compare
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
New Features
linux-aarch64andosx-arm64.Bug Fixes
Documentation
meta.yamlfile to reflect changes.openmptolibgomp.