Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix motor tab representation #4180

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 21, 2024

before:

Screenshot from 2024-09-21 22-19-09

after:

image

tooltip:

image

@haslinghuis haslinghuis added this to the 11.0 milestone Sep 21, 2024
@haslinghuis haslinghuis self-assigned this Sep 21, 2024
Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 15d6c3d
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66f1762841968c0008454be0
😎 Deploy Preview https://deploy-preview-4180.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctzsnooze
Copy link
Member

@haslinghuis - thanks! That's looking good!

Maybe:

  • instead of Motor Idle (%, static) we now say Motor Idle (%)`.
  • in the tooltip for dynamic idle:
The Motor Idle value sets the idle speed of the motors when throttle is at minimum position.

Dynamic Idle disabled
The lowest throttle value sent to any motor, while armed, as a percentage of full throttle.
Increase it to improve motor startup reliability, to avoid desyncs, and to improve PID responsiveness at low throttle.  Too low: the motors may not start up reliably, or desync at the end of a flip or roll or on hard throttle chops. Too high: the craft may feel 'floaty'.  

The 'Dynamic Idle enabled' text is fine.
We could add, Too low: the motors may not start up reliably. Too high: the craft may shake on the ground before takeoff.

@haslinghuis
Copy link
Member Author

haslinghuis commented Sep 22, 2024

Looking at the value - as motor idle is a percentage it still allows 200% ⁉️

@KarateBrot
Copy link
Member

"Dynamic RPM Enabled" should actually be "Dynamic Idle Enabled" I guess?

Copy link

sonarcloud bot commented Sep 23, 2024

@haslinghuis haslinghuis merged commit 7f3aacb into betaflight:master Sep 23, 2024
8 checks passed
@haslinghuis haslinghuis deleted the digitalidleoffset branch September 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

5 participants