Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA JRuby fix #49

Merged
merged 1 commit into from
Aug 24, 2023
Merged

ECDSA JRuby fix #49

merged 1 commit into from
Aug 24, 2023

Conversation

rchekaluk
Copy link
Collaborator

@rchekaluk rchekaluk commented Aug 24, 2023

This PR addresses JRuby failures noted here. Tested under rubies ruby-2.5.8, ruby-2.6.6, ruby-2.7.6, ruby-3.0.0, ruby-3.1.2, ruby-3.2.2, ruby-3.3.0-preview1, jruby-9.4.2.0, jruby-9.4.3, jruby-9.4.4.0

There are a couple of layered issues when using JRuby:

  • jruby-openssl does not suffer from "OpenSSL::PKey::PKeyError: pkeys are immutable on OpenSSL 3.0" like ruby-openssl, thus sshkey can continue using the original technique for determining public key
  • JRuby does not implement point_conversion_form, so note that explicitly in case it is used in the future
  • JRuby uses curve name "prime256v1" not its alias "secp256r1", so convert that explicitly in case it is used in the future

@bensie
Copy link
Owner

bensie commented Aug 24, 2023

Awesome work. Thank you!

@bensie bensie merged commit b5d3784 into bensie:main Aug 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants