use the github asset url information #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2023
Closed
This was referenced Jun 24, 2023
Closed
benbrittain
force-pushed
the
main
branch
5 times, most recently
from
7e637a9
to
b90a5cc
Compare
ahornby
changed the title
ahornby
force-pushed
the
pr8
branch
3 times, most recently
from
7332496
to
75985f8
Compare
benbrittain
force-pushed
the
main
branch
3 times, most recently
from
2f826da
to
e07221c
Compare
the use of the status code was included in a45d2c8, but the test was missed out so rebasing tested with: cargo test
using temp BUCKLE_CACKE stops tests taking the happy path where the user already has buck2 downloaded also check downloaded buck2 binary and prelude_hash are as expected tested with: cargo test
Use the github asset url information so we only download things it claims to have
Test Plan:
cargo test
local run and check the download and cache still work, notice the fetching message on first run
```
# Download
$ USE_BUCK2_VERSION=2023-07-15 cargo run -- --version
Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Running `target/debug/buckle --version`
buckle: fetching buck2-x86_64-unknown-linux-gnu.zst 2023-07-15
buck2 22862e81827fad189f124d677c623d7ec1772cc6 <local>
# see its cached
$ USE_BUCK2_VERSION=2023-07-15 cargo run -- --version
Sat 22 Jul 19:23:14 BST 2023
Finished dev [unoptimized + debuginfo] target(s) in 0.04s
Running `target/debug/buckle --version`
buck2 22862e81827fad189f124d677c623d7ec1772cc6 <local>
Sat 22 Jul 19:23:14 BST 2023 [Exit: 0] alex@fridge:~/loca
```
|
closing, looks like OSS dotslash covers the usecases I was interested in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the github asset url information
Use the github asset url information so we only download things it claims to have
Test Plan:
cargo test
local run and check the download and cache still work, notice the fetching message on first run
Stack created with Sapling. Best reviewed with ReviewStack.