Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of static variables #6281

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix usage of static variables #6281

wants to merge 2 commits into from

Conversation

jamieburchell
Copy link
Contributor

@jamieburchell jamieburchell commented May 16, 2024 •
edited
Loading

Fixes problematic use of static variables in inherited methods in PHP >= 8.1

See:

Notes:

  • There is a mixture of "char" and "chr" naming conventions so I just chose one.
  • There are other instances where static variables are used in database classes but I do not know if these are problematic. I think not if they are introduced in what are essentially final classes, but I have not tested or verified.

@jamieburchell jamieburchell mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamieburchell