-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing interface for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR property #113
Added missing interface for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR property #113
Conversation
I see the error from windows build:
I am calling plain |
… to handle CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this!
to distinguish between CL_SEMAPHORE_DEVICE_HANDLE_LIST_END_KHR and array terminator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The latest version LGTM.
I'm going to go ahead and merge this even though there are CI failures because I think the failures are unrelated and already fixed in the main branch. |
* Added missing interface for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR property * approach to correct CI checks errors around semaphore emulation layer to handle CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR flag * Corrections related to negative CTS tests of clCreateSemaphoreWithPropertiesKHR * corrections related to review #113 * Take into account additional property field to distinguish between CL_SEMAPHORE_DEVICE_HANDLE_LIST_END_KHR and array terminator --------- Co-authored-by: Ben Ashbaugh <[email protected]>
Completed during work on CTS PR