Add functionality to compare pipelines #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JochenSiegWork
approved these changes
Oct 2, 2024
tests/test_utils/test_comparison.py
Outdated
| from molpipeline.utils.comparison import check_pipelines_equivalent | ||
|
|
||
|
|
||
| def get_test_pipeline() -> Pipeline: |
There was a problem hiding this comment.
do we have such a function already in the library somewhere? Maybe put it into the test utils
There was a problem hiding this comment.
Moved it to tests/utils/default_models.py.
We have done something similar for Chemprop (see test_extras/test_chemprop/chemprop_test_utils/default_models.py)
c-w-feldmann
deleted the
94-utils-add-a-function-to-compare-is-two-pipelines-have-same-functionallity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.