68 makescaffoldgeneric set all carbons to wild card symbols to allow a substrcutre search #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbons-to-wild-card-symbols-to-allow-a-substrcutre-search # Conflicts: # molpipeline/mol2mol/scaffolds.py
JochenSiegWork
requested changes
Aug 23, 2024
There was a problem hiding this comment.
The commit message mentions that these changes help with substructure search. Based on the code changes it's not obvious to me how you would want to do a substructure search with generic atoms/bonds. Can you explain this to me or even in the docs if it fits there?
JochenSiegWork
requested changes
Aug 30, 2024
JochenSiegWork
approved these changes
Sep 6, 2024
c-w-feldmann
deleted the
68-makescaffoldgeneric-set-all-carbons-to-wild-card-symbols-to-allow-a-substrcutre-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.