Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission::getPermissionGroupType #3861

Open
wants to merge 6 commits into
base: 5.1.x
Choose a base branch
from
Open

Permission::getPermissionGroupType #3861

wants to merge 6 commits into from

Conversation

thangnnmd
Copy link
Collaborator

No description provided.

@HungDV2022 HungDV2022 removed their assignment Oct 3, 2024
@thangnnmd thangnnmd assigned HungDV2022 and unassigned thangnnmd Oct 3, 2024
@HungDV2022
Copy link
Collaborator

@ryuring レビューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Oct 3, 2024
@ryuring
Copy link
Collaborator

ryuring commented Oct 4, 2024

@thangnnmd @HungDV2022 $this->_fields['permission_group_type'] がセットされている場合のテストもお願いします。

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Oct 4, 2024
@ryuring ryuring added the Reviewed レビュー済 label Oct 4, 2024
@thangnnmd thangnnmd removed their assignment Oct 4, 2024
@HungDV2022
Copy link
Collaborator

@ryuring ユニットテストを追加しました。レビューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HungDV2022 HungDV2022 HungDV2022 left review comments

Assignees

@ryuring ryuring

Labels
Reviewed レビュー済
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thangnnmd @HungDV2022 @ryuring