Add Nethermind #329
Open
Add Nethermind #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
stdevMac
force-pushed
the
feat/add_nethermind
branch
from
e17fd00
to
fb6630c
Compare
stdevMac
force-pushed
the
feat/add_nethermind
branch
from
c902bd2
to
2805814
Compare
mdehoog
reviewed
Sep 29, 2024
Co-authored-by: Michael de Hoog <[email protected]>
mdehoog
reviewed
Sep 29, 2024
nethermind/Dockerfile
Outdated
| ENV REPO=https://github.com/NethermindEth/nethermind.git | ||
| ENV VERSION=1.29.0 | ||
| ENV COMMIT=917f5349517118bf5c73c362c3902d61e68e5b40 | ||
| RUN git clone $REPO --branch release/$VERSION --single-branch . && \ |
There was a problem hiding this comment.
Could we depend on a tagged commit rather than a branch (perhaps when the 1.29.0 release is tagged)? Otherwise new commits on that branch will break the build.
There was a problem hiding this comment.
Yes, shipping this week likely
There was a problem hiding this comment.
Suggested change
| RUN git clone $REPO --branch release/$VERSION --single-branch . && \ | |
| RUN git clone $REPO --branch $VERSION --single-branch . && \ |
to switch to tag rather than branch
Feat/add nethermind
fix: update release/1.29.0 commit
fix: build on nethermind
fix: build on nethermind, buildx command
fix: build on nethermind, labels breaking buildx
fix: build on nethermind, labels breaking buildx again
fix: build on nethermind, buildx
fix: build on nethermind, buildx labels
fix: build on nethermind, buildx labels, now as cmd
fix: build on nethermind, buildx labels
fix: update with sed targetarch
fix: upgrade build action on nethermind to use buildx
stdevMac
force-pushed
the
feat/add_nethermind
branch
from
4d3d8c8
to
8a051cd
Compare
fix: update dockerfile
fix: update commit release 1.29.0
stdevMac
force-pushed
the
feat/add_nethermind
branch
from
937e206
to
0eaafdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for the Nethermind Ethereum client on Base Chain.
The changes include: