forked from StarRocks/starrocks-connector-for-apache-flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Enhancement] Don't retry for some exceptions
Signed-off-by: PengFei Li <[email protected]>
- Loading branch information
Showing
8 changed files
with
177 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...ks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/exception/ErrorUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Copyright 2021-present StarRocks, Inc. All rights reserved. | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.starrocks.data.load.stream.exception; | ||
|
|
||
| import com.starrocks.data.load.stream.StreamLoadResponse; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import static com.starrocks.data.load.stream.StreamLoadConstants.RESULT_STATUS_FAILED; | ||
| import static com.starrocks.data.load.stream.StreamLoadConstants.RESULT_STATUS_INTERNAL_ERROR; | ||
|
|
||
| public class ErrorUtils { | ||
|
|
||
| private static final List<String> UNRETRYABLE_FAIL_MESSAGE_KEY_WORDS = Arrays.asList( | ||
| "too many filtered rows".toLowerCase(), | ||
| "primary key size exceed the limit".toLowerCase(), | ||
| "Only primary key table support partial update".toLowerCase(), | ||
| "Access denied".toLowerCase(), | ||
| "current running txns on db".toLowerCase() | ||
| ); | ||
|
|
||
| public static boolean isRetryable(Throwable e) { | ||
| if (!(e instanceof StreamLoadFailException)) { | ||
| return true; | ||
| } | ||
|
|
||
| StreamLoadFailException exception = (StreamLoadFailException) e; | ||
| StreamLoadResponse.StreamLoadResponseBody responseBody = exception.getResponseBody(); | ||
| if (responseBody == null) { | ||
| return true; | ||
| } | ||
|
|
||
| if (!RESULT_STATUS_FAILED.equalsIgnoreCase(responseBody.getStatus()) | ||
| || !RESULT_STATUS_INTERNAL_ERROR.equalsIgnoreCase(responseBody.getStatus())) { | ||
| return false; | ||
| } | ||
|
|
||
| String failMsg = responseBody.getMessage(); | ||
| if (failMsg == null) { | ||
| return true; | ||
| } | ||
|
|
||
| failMsg = failMsg.toLowerCase(); | ||
| for (String keyword : UNRETRYABLE_FAIL_MESSAGE_KEY_WORDS) { | ||
| if (failMsg.contains(keyword)) { | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...tream-load-sdk/src/test/java/com/starrocks/data/load/stream/exception/ErrorUtilsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Copyright 2021-present StarRocks, Inc. All rights reserved. | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.starrocks.data.load.stream.exception; | ||
|
|
||
| import com.starrocks.data.load.stream.StreamLoadConstants; | ||
| import com.starrocks.data.load.stream.StreamLoadResponse; | ||
| import org.junit.Test; | ||
|
|
||
| import static com.starrocks.data.load.stream.StreamLoadConstants.RESULT_STATUS_FAILED; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| public class ErrorUtilsTest { | ||
|
|
||
| @Test | ||
| public void testRetryable() { | ||
| assertTrue(ErrorUtils.isRetryable(new Exception())); | ||
| assertTrue(ErrorUtils.isRetryable(new StreamLoadFailException("unknown"))); | ||
|
|
||
| StreamLoadResponse.StreamLoadResponseBody body1 = new StreamLoadResponse.StreamLoadResponseBody(); | ||
| body1.setStatus(StreamLoadConstants.RESULT_STATUS_LABEL_EXISTED); | ||
| assertFalse(ErrorUtils.isRetryable(new StreamLoadFailException("test", body1))); | ||
|
|
||
| StreamLoadResponse.StreamLoadResponseBody body2 = new StreamLoadResponse.StreamLoadResponseBody(); | ||
| body2.setStatus(RESULT_STATUS_FAILED); | ||
| body2.setMessage("memory exceed"); | ||
| assertTrue(ErrorUtils.isRetryable(new StreamLoadFailException("test", body2))); | ||
|
|
||
| StreamLoadResponse.StreamLoadResponseBody body3 = new StreamLoadResponse.StreamLoadResponseBody(); | ||
| body3.setStatus(RESULT_STATUS_FAILED); | ||
| body3.setMessage("too many filtered rows"); | ||
| assertFalse(ErrorUtils.isRetryable(new StreamLoadFailException("test", body3))); | ||
| } | ||
| } |