Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward streams errors #27

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Forward streams errors #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ffffac
Forward streams errors if cause is recoverable
philipp94831 Mar 21, 2024
72ccda6
Forward streams errors if cause is recoverable
philipp94831 Mar 21, 2024
2f7bc6c
Forward streams errors if cause is recoverable
philipp94831 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions error-handling-core/src/main/java/com/bakdata/kafka/ErrorUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.Objects;
import java.util.Set;
import lombok.experimental.UtilityClass;
import lombok.extern.slf4j.Slf4j;
import org.apache.avro.Schema;
Expand All @@ -51,6 +52,11 @@
public class ErrorUtil {

private static final String ORG_APACHE_KAFKA_COMMON_ERRORS = "org.apache.kafka.common.errors";
private static final String ORG_APACHE_KAFKA_STREAMS_ERRORS = "org.apache.kafka.streams.errors";
private static final Set<String> RECOVERABLE_ERROR_PACKAGES = Set.of(
ORG_APACHE_KAFKA_COMMON_ERRORS,
ORG_APACHE_KAFKA_STREAMS_ERRORS
);

/**
* Check if an exception is recoverable and thus should be thrown so that the process is restarted by the execution
Expand All @@ -68,8 +74,8 @@ public static boolean isRecoverable(final Exception e) {
}

/**
* Check if an exception is thrown by Kafka, i.e., located in package {@code org.apache.kafka.common.errors}, and is
* recoverable.
* Check if an exception is thrown by Kafka, i.e., located in package {@code org.apache.kafka.common.errors} or
* {@code org.apache.kafka.streams.errors}, and is recoverable.
* <p>Non-recoverable Kafka errors are:
* <ul>
* <li>{@link RecordTooLargeException}
Expand All @@ -79,7 +85,7 @@ public static boolean isRecoverable(final Exception e) {
* @return whether exception is thrown by Kafka and recoverable or not
*/
public static boolean isRecoverableKafkaError(final Exception e) {
if (ORG_APACHE_KAFKA_COMMON_ERRORS.equals(e.getClass().getPackageName())) {
if (RECOVERABLE_ERROR_PACKAGES.contains(e.getClass().getPackageName())) {
return !(e instanceof RecordTooLargeException);
}
return false;
Expand Down
4 changes: 3 additions & 1 deletion error-handling-core/src/test/java/com/bakdata/kafka/ErrorUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import java.util.stream.Stream;
import org.apache.kafka.common.errors.SerializationException;
import org.apache.kafka.streams.errors.StreamsException;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
Expand All @@ -47,7 +48,8 @@ static Stream<Arguments> generateConvertToStringParameters() {
static Stream<Arguments> generateIsRecoverableExceptionParameters() {
return Stream.of(
Arguments.of(mock(Exception.class), false),
Arguments.of(new SerializationException(), true)
Arguments.of(new SerializationException(), true),
Arguments.of(new StreamsException("message"), true)
);
}

Expand Down
Loading